[AWS] Add LB Type in the infrastructure cluster object via install-config yaml#6074
[AWS] Add LB Type in the infrastructure cluster object via install-config yaml#6074miheer wants to merge 3 commits intoopenshift:masterfrom
Conversation
miheer
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
miheer
changed the title
miheer
force-pushed
the
nlb-field
branch
2 times, most recently
from
4ab0b8a to
bd223a6
Compare
miheer
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
miheer
force-pushed
the
nlb-field
branch
3 times, most recently
from
16644a8 to
850c399
Compare
|
/retest |
|
Please separate vendoring into a separate commit to make reviewing easier. It would also be good to separate the pr into logical, smaller commits per the contributing guidelines. Are there any reference links for this work such as an enhancement or jira cards? |
|
@patrickdillon thanks! I have done the changes you asked for. Please do let me know if anything is needed. I have added the commit message in detail as to which file does what. Also reference to enhancement proposal, API and jira ticket have been added in the commit message. I am adding them here as well - |
|
/retest-required |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
miheer
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
openshift/release#32996 should make unit and verify-codegen tests optional. |
|
/refresh |
|
/test okd-scos-verify-codegen |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/skip |
|
/retest-required |
|
/unshrug |
|
@LorbusChris: ¯\_(ツ)_/¯ DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test okd-scos-images |
|
/retest images |
|
@LorbusChris: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test images |
|
@miheer this PR needs a rebase |
openshift-merge-robot
added
the
needs-rebase
|
@miheer: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@miheer: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Before, the only merge conflict was: Now, there are also: |
|
This PR has been open a while and now, there is no need to vendor anything because the current openshift-api version is: I'm going to try to remove the vendoring commits, but not sure if I can modify this PR. |
|
I have opened #6478 in lieu of this one so I could modify. I just removed the vendoring changes and rebased. PTAL |
|
/close |
|
/close |
|
@r4f4: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9 participants
In the ingress config cluster object we need to add api for AwsLBType which will store and persist the information of the desired LB type mentioned by the installer config API so that the ingress operator will refer the LB type from this object whenever someone accidentally deletes the ingress controller.
Currently, the default LB type i.e CLB/ELB gets set if you delete the ingress controller object even when the desired the LB type for default ingress controller
was set to NLB as ingress operator does not have a way to check the LB type as we don't store it.
This commit adds LB Type for AWS mentioned in the install-config.yaml in the infrastructure cluster object.
data/data/install.openshift.io_installconfigs.yamlA generated new field called lbType will be available to add load balancer type in the install-config.yaml for AWSpkg/asset/manifests/ingress.goThe ingress cluster object will be patched with this lbType provided by user so that we have the information related to the lbType persistent which can be referred by ingress operator when the default ingress controller is deleted.pkg/asset/manifests/ingress_test.goUnit test to test setting of lbType in the ingress cluster object's spec and status as per the value specified in the install-config.yamlpkg/explain/printer_test.goA new field to test called lbType which will be available to add the load balancer type in the install-config.yaml for AWSpkg/types/aws/platform.goA new field called lbType will be available to add the load balancer type in the install-config.yaml for AWSEnhacement proposal - openshift/enhancements#1148
OpenShift API - openshift/api#1209
Jira ticket - https://issues.redhat.com/browse/NE-942